From efa0c060fe15804cdab60eb32bea0cda3ebae905 Mon Sep 17 00:00:00 2001
From: Jakob Ketterl <jakob.ketterl@gmx.de>
Date: Sat, 15 Jun 2019 13:29:59 +0200
Subject: [PATCH] implement digiham version check

---
 owrx/feature.py | 30 ++++++++++++++++++++++--------
 1 file changed, 22 insertions(+), 8 deletions(-)

diff --git a/owrx/feature.py b/owrx/feature.py
index a430c0d..38d3fa7 100644
--- a/owrx/feature.py
+++ b/owrx/feature.py
@@ -2,6 +2,8 @@ import os
 import subprocess
 from functools import reduce
 from operator import and_
+import re
+from distutils.version import LooseVersion
 
 import logging
 logger = logging.getLogger(__name__)
@@ -18,7 +20,7 @@ class FeatureDetector(object):
         "hackrf": [ "hackrf_transfer" ],
         "airspy": [ "airspy_rx" ],
         "digital_voice_digiham": [ "digiham", "sox" ],
-        "digital_voice_dsd": [ "dsd", "sox" ]
+        "digital_voice_dsd": [ "dsd", "sox", "digiham" ]
     }
 
     def feature_availability(self):
@@ -82,19 +84,31 @@ class FeatureDetector(object):
     def command_exists(self, command):
         return os.system("which {0}".format(command)) == 0
 
+    """
+    To use DMR and YSF, the digiham package is required. You can find the package and installation instructions here:
+    https://github.com/jketterl/digiham
+    
+    Please note: there is close interaction between digiham and openwebrx, so older versions will probably not work.
+    If you have an older verison of digiham installed, please update it along with openwebrx.
+    As of now, we require version 0.2 of digiham.
+    """
     def has_digiham(self):
-        # the digiham tools expect to be fed via stdin, they will block until their stdin is closed.
-        def check_with_stdin(command):
+        required_version = LooseVersion("0.2")
+
+        digiham_version_regex = re.compile('^digiham version (.*)$')
+        def check_digiham_version(command):
             try:
-                process = subprocess.Popen(command, stdin=subprocess.PIPE)
-                process.communicate("")
-                return process.wait() == 0
+                process = subprocess.Popen([command, "--version"], stdout=subprocess.PIPE)
+                version = LooseVersion(digiham_version_regex.match(process.stdout.readline().decode())[1])
+                process.wait(1)
+                return version >= required_version
             except FileNotFoundError:
                 return False
         return reduce(and_,
                       map(
-                          check_with_stdin,
-                          ["rrc_filter", "ysf_decoder", "dmr_decoder", "mbe_synthesizer", "gfsk_demodulator"]
+                          check_digiham_version,
+                          ["rrc_filter", "ysf_decoder", "dmr_decoder", "mbe_synthesizer", "gfsk_demodulator",
+                           "digitalvoice_filter"]
                       ),
                       True)